Refresh network when connection is reset#1235
Merged
Conversation
3 tasks
The `resetConnction` method has been updated to match the extension more closely. We now refresh the network when this is called, rather than just reconstructing the provider and checking EIP1559 status. Unit tests have been updated to align more closely with the extension as well. This was done to unblock #1203, but it also relates to #1023
Gudahtt
force-pushed
the
refresh-network-when-connection-is-reset
branch
from
c88d819 to
b319771
Compare
Contributor
|
This change is only affecting tests since the function is not exported or referenced elsewhere, correct? |
Member
Author
|
Correct. This will be used on the extension, but it's not yet. And this PR moves it closer to how the extension |
mcmire
approved these changes
Apr 21, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `resetConnction` method has been updated to match the extension more closely. We now refresh the network when this is called, rather than just reconstructing the provider and checking EIP1559 status. Unit tests have been updated to align more closely with the extension as well. This was done to unblock #1203, but it also relates to #1023 Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `resetConnction` method has been updated to match the extension more closely. We now refresh the network when this is called, rather than just reconstructing the provider and checking EIP1559 status. Unit tests have been updated to align more closely with the extension as well. This was done to unblock #1203, but it also relates to #1023 Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
resetConnctionmethod has been updated to match the extension more closely. We now refresh the network when this is called, rather than just reconstructing the provider and checking EIP1559 status.Unit tests have been updated to align more closely with the extension as well.
Changes
resetConnectionto perform network lookup (refresh network id and status)References
This was done to unblock #1203, but it also relates to #1023 and #1176
Checklist