Merged
Conversation
The `setProviderType` unit tests included a static set of network metadata that was not being used. It has been updated to use a list of just the network types, following examples in other tests.
Gudahtt
commented
Apr 20, 2023
| result: { | ||
| baseFeePerGas: '0x1', | ||
| }, | ||
| [NetworkType.mainnet, NetworkType.goerli, NetworkType.sepolia].forEach( |
Member
Author
There was a problem hiding this comment.
I'd strongly recommend hiding whitespace when looking at this diff. This line is basically the only one with changes, the rest are indentation/lint changes.
legobeat
approved these changes
Apr 20, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `setProviderType` unit tests included a static set of network metadata that was not being used. It has been updated to use a list of just the network types, following examples in other tests.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `setProviderType` unit tests included a static set of network metadata that was not being used. It has been updated to use a list of just the network types, following examples in other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
setProviderTypeunit tests included a static set of network metadata that was not being used. It has been updated to use a list of just the network types, following examples in other tests.Changes
None
References
This was done in pursuit of #1203, though the connection is fairly indirect (I'm on a tangent here)
Checklist