Stub PreferencesController in KeyringController tests#1194
Merged
mikesposito merged 4 commits intomainfrom Apr 20, 2023
Merged
Conversation
mikesposito
force-pushed
the
test/stub-preferences-controller
branch
from
00df9d6 to
d52da13
Compare
Gudahtt
previously approved these changes
Apr 20, 2023
mikesposito
force-pushed
the
test/stub-preferences-controller
branch
from
0143173 to
ebf3e0e
Compare
Gudahtt
approved these changes
Apr 20, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* test: stub preferences controller in keyring tests * test: refactor addNewAccountWithoutUpdate * refactor: keyringController instantiation
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* test: stub preferences controller in keyring tests * test: refactor addNewAccountWithoutUpdate * refactor: keyringController instantiation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stubs the PreferencesController used to create the KeyringController instance used in tests.
Changes
References
Checklist