Conversation
The internal method `verifyNetwork` is now async. It performed an async call but didn't `await` it. This method is only invoked as an internal event handler, so this didn't require any changes outside of that function (not even to tests). Effectively this is not a functional change in any way. This relates to #1176
Gudahtt
force-pushed
the
make-verify-network-async
branch
from
38da81d to
aed9ff3
Compare
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The internal method `verifyNetwork` is now async. It performed an async call but didn't `await` it. This method is only invoked as an internal event handler, so this didn't require any changes outside of that function (not even to tests). Effectively this is not a functional change in any way. This relates to #1176
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The internal method `verifyNetwork` is now async. It performed an async call but didn't `await` it. This method is only invoked as an internal event handler, so this didn't require any changes outside of that function (not even to tests). Effectively this is not a functional change in any way. This relates to #1176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The internal method
verifyNetworkis now async. It performed an async call but didn'tawaitit.This method is only invoked as an internal event handler, so this didn't require any changes outside of that function (not even to tests). Effectively this is not a functional change in any way.
Changes
N/A
References
This relates to #1176
Checklist