Skip to content

Eliminate console error when running test #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gudahtt merged 3 commits into from
Apr 14, 2023
Merged

Eliminate console error when running test #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bb68f8
Eliminate console error when running test
Gudahtt Apr 13, 2023
9b53602
Eliminate error in second test
Gudahtt Apr 14, 2023
31f08e3
Merge branch 'main' into eliminate-network-client-queued-request-test…
Gudahtt Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/network-controller/tests/provider-api-tests/block-param.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ export const testsForRpcMethodSupportingBlockParam = (
// block-cache middleware will request the latest block number
// through the block tracker to determine the cache key.
comms.mockNextBlockTrackerRequest();
// A second block tracker request is made for some reason
comms.mockNextBlockTrackerRequest();
comms.mockRpcCall({
delay: 100,
request: buildRequestWithReplacedBlockParam(
Expand Down
4 changes: 3 additions & 1 deletion packages/network-controller/tests/provider-api-tests/no-block-param.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const testsForRpcMethodAssumingNoBlockParam = (
});

for (const paramIndex of [...Array(numberOfParameters).keys()]) {
it(`does not reuse the result of a previous request if parameter at index "${paramIndex}" differs`, async () => {// eslint-disable-line
it(`does not reuse the result of a previous request if parameter at index "${paramIndex}" differs`, async () => {
Copy link
Member Author

@Gudahtt Gudahtt Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor removed this when I formatted the document. I'm not sure why it was there in the first place, but it appears to have been unnecessary.

const firstMockParams = [
...new Array(numberOfParameters).fill('some value'),
];
Expand Down Expand Up @@ -215,6 +215,8 @@ export const testsForRpcMethodAssumingNoBlockParam = (
// number is retrieved through the block tracker first. It doesn't
// matter what this is — it's just used as a cache key.
comms.mockNextBlockTrackerRequest();
// A second block tracker request is made for some reason
comms.mockNextBlockTrackerRequest();
comms.mockRpcCall({
request: requests[0],
response: { result: mockResults[0] },
Expand Down