Skip to content

Fix test description#1175

Merged
Gudahtt merged 1 commit intomainfrom
fix-test-description
Apr 13, 2023
Merged

Fix test description#1175
Gudahtt merged 1 commit intomainfrom
fix-test-description

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 13, 2023

A network client test description has been updated to reflect what the test is demonstrating. The current description contradicts the test.

Changes

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

A network client test description has been updated to reflect what the
test is demonstrating. The current description contradicts the test.
@Gudahtt Gudahtt marked this pull request as ready for review April 13, 2023 13:40
@Gudahtt Gudahtt requested a review from a team as a code owner April 13, 2023 13:40
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right, good catch.

@Gudahtt Gudahtt merged commit 49a502b into main Apr 13, 2023
@Gudahtt Gudahtt deleted the fix-test-description branch April 13, 2023 15:56
@legobeat legobeat mentioned this pull request Apr 25, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
A network client test description has been updated to reflect what the
test is demonstrating. The current description contradicts the test.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
A network client test description has been updated to reflect what the
test is demonstrating. The current description contradicts the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants