add rollbackToPreviousProvider method#1132
Merged
Conversation
adonesky1
force-pushed
the
add-rollback-to-previous-provider
branch
2 times, most recently
from
3492ae6 to
ae2603d
Compare
mcmire
reviewed
Mar 16, 2023
adonesky1
force-pushed
the
migrate-network-configs-to-network-controller
branch
3 times, most recently
from
f659097 to
479e349
Compare
adonesky1
force-pushed
the
add-rollback-to-previous-provider
branch
5 times, most recently
from
cc23734 to
b0f9743
Compare
mcmire
reviewed
Mar 20, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
This is looking good! Just a few comments
| ) { | ||
| super(config, state); | ||
| this.defaultConfig = { | ||
| networkType: MAINNET, |
Contributor
There was a problem hiding this comment.
Nice! Yeah this is much better.
| rpc = 'rpc', | ||
| } | ||
|
|
||
| export const isNetworkType = (val: any): val is NetworkType => { |
Contributor
There was a problem hiding this comment.
Thoughts on making this a function instead of a const? I believe this will enforce that this is JSDoc'd as well.
adonesky1
force-pushed
the
add-rollback-to-previous-provider
branch
from
ceb710d to
49b5222
Compare
Contributor
Author
Base automatically changed from
migrate-network-configs-to-network-controller
to
main
March 22, 2023 19:38
adonesky1
force-pushed
the
add-rollback-to-previous-provider
branch
from
1500a6e to
8061393
Compare
mcmire
reviewed
Mar 22, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One small thing, but other than that, good to go.
| @@ -1,5 +1,6 @@ | |||
| /* eslint-disable jest/require-top-level-describe, jest/no-export, jest/no-identical-title, jest/no-if */ | |||
|
|
|||
| import { NetworkType } from '@metamask/controller-utils/src'; | |||
Contributor
There was a problem hiding this comment.
Are we exporting this type from controller-utils? If so, I think we can drop the /src.
Contributor
Author
There was a problem hiding this comment.
oh... weird not sure how that happened!
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add rollbackToPreviousProvider method
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add rollbackToPreviousProvider method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADDED:
rollbackToPreviousProvidermethod like the one that exists on the extension sideNetworkControllerResolves #1024