parse decimals without leading integer, e.g. .1#1407
Merged
sploiselle merged 1 commit intoMaterializeInc:masterfrom Dec 30, 2019
sploiselle:parse-numbers-begin-decimal
Merged
parse decimals without leading integer, e.g. .1#1407sploiselle merged 1 commit intoMaterializeInc:masterfrom sploiselle:parse-numbers-begin-decimal
sploiselle merged 1 commit intoMaterializeInc:masterfrom
sploiselle:parse-numbers-begin-decimal
Conversation
sploiselle
added
A-sql
Contributor
|
Oh, sorry, I gave you a bad counterexample but I think the issue does exist. Specifically it seems like something like |
benesch
reviewed
Dec 30, 2019
| Expr::Value(Value::Number(bigdecimal::BigDecimal::from(.1))) | ||
| ); | ||
|
|
||
| #[cfg(not(feature = "bigdecimal"))] |
Contributor
There was a problem hiding this comment.
Oh, also, I deleted the bigdecimal feature, so if you remember you can drop the bigdecimal conditional here, and just delete the hunk above entirely.
Contributor
|
Although not to clippy, apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving MaterializeInc/sqlparser#33 over
Added test case to assuage concern of parsing something like
..07as a valid number...07doesn't pass parsing because there are no expressions that begin with with a period; this is the same as the current behavior when trying to parse.07, which results in a SQL parsing error:@benesch lmk if you'd still like this refactored!