Skip to content

Update excluded paths in .fortlsrc#1248

Merged
sbryngelson merged 10 commits intoMFlowCode:masterfrom
sbryngelson:test-claude-4
Feb 22, 2026
Merged

Update excluded paths in .fortlsrc#1248
sbryngelson merged 10 commits intoMFlowCode:masterfrom
sbryngelson:test-claude-4

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Feb 22, 2026

User description

Removed excluded paths from .fortlsrc configuration.

Description

Summarize your changes and the motivation behind them.

Fixes #(issue)

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other: describe

Testing

How did you test your changes?

Checklist

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

CodeAnt-AI Description

Include previously excluded files in Fortran language server indexing

What Changed

  • Removed several paths from the Fortran language server config so files previously ignored (misc/ and specific hardcoded initial-condition include files under src/pre_process/include) are now included
  • Those files will now be indexed and show up in code navigation, symbol search, and editor diagnostics
  • No changes to source directories or include directory list

Impact

✅ Language server indexes pre_process include files
✅ Diagnostics available for previously excluded files
✅ Code navigation available in misc/ and the restored include files

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Chores
    • Updated code analysis configuration to include additional source files in processing.
    • Enhanced automated code review workflow with improved output visibility and tool constraints.

Removed excluded paths from .fortlsrc configuration.
Copilot AI review requested due to automatic review settings February 22, 2026 22:15
@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 22, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The PR removes FortLS exclusions for the misc/ directory and three hardcoded IC pre-processor include files, enabling those files to participate in FortLS analysis. Additionally, the Claude code review GitHub Actions workflow is updated with full output display, Bash-only tool restrictions, and an expanded prompt message.

Changes

Cohort / File(s) Summary
FortLS Configuration
.fortlsrc
Removes four exclusion entries: misc/ directory and three pre_process include files (2dHardcodedIC.fpp, 3dHardcodedIC.fpp, ExtrusionHardcodedIC.fpp), allowing these files to be parsed and analyzed.
GitHub Actions Workflow
.github/workflows/claude-code-review.yml
Updates Claude code review workflow with show_full_output: true, claude_args: '--allowed-tools Bash', and expands prompt to include "Claude Code Review" title and blocking issue notification directive.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

size:M

Poem

🐰 Exclusions fade like morning dew,
Files now welcome, old and new,
Claude's review grows sharp and keen,
With Bash alone and output clean! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing excluded paths from .fortlsrc configuration, which aligns with the primary objective of the pull request.
Description check ✅ Passed The description follows the required template structure with sections for Description, Type of change, Testing, and Checklist, though several fields remain incomplete or unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codeant-ai
Copy link
Contributor

codeant-ai bot commented Feb 22, 2026

CodeAnt AI finished reviewing your PR.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Fortran Language Server configuration (.fortlsrc) by simplifying the excluded-paths list, keeping the project’s fortls indexing focused on core source areas.

Changes:

  • Removed misc/ from excl_paths.
  • Removed several src/pre_process/include/*HardcodedIC.fpp entries from excl_paths.

Updated prompt format for code review action and added option to show full output.
Added claude_args to specify allowed tools for the code review.
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/claude-code-review.yml:
- Line 31: The workflow contains an unsupported parameter show_full_output: true
for the claude-code-action@v1 step; remove the show_full_output key (and its
value) from the claude-code-action@v1 configuration so only supported inputs
remain, ensuring the action uses only recognized parameters for
claude-code-action@v1.
- Line 33: The claude_args entry uses the wrong flag and an overly permissive
spec; change the value to use camelCase "--allowedTools" instead of
"--allowed-tools" and replace the broad "Bash" allowance with a tightly scoped
pattern following the Claude CLI syntax (for example restrict to specific
commands/paths or explicit tool names rather than permitting all Bash commands);
update the claude_args setting (symbol: claude_args) so it contains the
corrected "--allowedTools" flag and a scoped tool pattern instead of the plain
"Bash".

@sbryngelson sbryngelson merged commit 1fcb45a into MFlowCode:master Feb 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants