Add test sharding, proactive clean, and retry logic for self-hosted CI#1171
Merged
sbryngelson merged 17 commits intoMFlowCode:masterfrom Feb 28, 2026
Merged
Add test sharding, proactive clean, and retry logic for self-hosted CI#1171sbryngelson merged 17 commits intoMFlowCode:masterfrom
sbryngelson merged 17 commits intoMFlowCode:masterfrom
Conversation
submit.sh now auto-detects job type (bench vs test) from the submitted script's basename, selecting the appropriate SBATCH account, time limit, and partition. This eliminates three submit-bench.sh files and makes frontier/ and frontier_amd/ scripts byte-identical via directory-name detection for compiler flags and cluster-specific options. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Raise MFCException when --shard produces zero cases (prevents silent green CI with nothing executed) - Pin nick-fields/retry to commit SHA for security on self-hosted runners with cluster credentials Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace per-case case-optimized builds with one generic build, reducing build time from ~34 min to ~5-10 min. Halve benchmark timesteps to compensate for slower non-optimized runtime. Reduce GPU --mem from 12 to 4 GB. Lower test build retry timeout from 480 to 60 minutes. Closes MFlowCode#1275 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 44.05% 44.04% -0.02%
==========================================
Files 70 70
Lines 20496 20499 +3
Branches 1991 1993 +2
==========================================
- Hits 9029 9028 -1
- Misses 10328 10330 +2
- Partials 1139 1141 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens self-hosted CI with test sharding, retry logic, and script deduplication.
Test sharding & retry
--shard i/nflag to./mfc.sh test— splits tests via modular arithmetic for even distribution--onlyand--shard— empty results raise an error instead of silent green CItests/failed_uuids.txtfailed_uuids.txtto prevent stale retries--onlyfilter improvements--onlymatching zero tests now raises an error instead of silently passingCI script consolidation
submit-bench.shintosubmit.shfor all 3 clusters (frontier, frontier_amd, phoenix) —submit.shauto-detects bench vs test mode from the submitted script's basenamefrontier/andfrontier_amd/scripts via directory-name detection —build.sh,bench.sh,submit.sh, andtest.share now byte-identical across both directoriesOther
--qos=normalon batch partition (1h59m, CFD154 account)--requeueon Phoenix SLURM jobs for preemption recoverynick-fields/retryto commit SHA for security on self-hosted runnersDepends on: #1170
Test plan
--requeueand preemption recoverysubmit.sh(bench mode auto-detected)frontier/andfrontier_amd/scripts are identical and detect cluster correctly--shardwith zero resulting tests raises an error (not silent pass)