Conversation
I will need @billstackpole to test this. Probably fixes #40.
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
proceed to control after bond request
ps2
pushed a commit
that referenced
this pull request
May 12, 2020
* LOOP-1179: Implement Alert Sounds Introduces a new "AlertSoundVendor" abstraction, which DeviceManagers now can implement in order to vend sounds to play with alerts. The sounds are simply named as part of the DeviceAlert to play. Sound configuration is still up to the device's settings UI. This adds the ability to: 1. Copy Alert Sounds to /Library/Sounds from each device manager (they need to be there for UserNotifications to find them, and for convenience we play them from that same location in-app) 2. Play those sounds either in the in-app modal or the UserNotification * Promote AlertSoundPlayer to LoopKit ...that way, it can be used elsewhere for playing alert sounds. * PR Feedback: Make DeviceAlert.SoundName a struct * More PR feedback * Build fix * More PR feedback: Make SoundName a first-class enum (and name it just "Sound") * PR Feedback * Remove unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will need @billstackpole to test this. Probably fixes #40.