Conversation
ps2
pushed a commit
that referenced
this pull request
Jan 10, 2022
…t.isCritical` (#487) * LOOP-3973: Introducing `interruptionLevel` as a replacement for `Alert.isCritical` This introduces the notion of three Alert "interruption levels" similar to iOS's UNNotificationInterruptionLevel (https://developer.apple.com/documentation/usernotifications/unnotificationinterruptionlevel) as a replacement of the `isCritical` flag. https://tidepool.atlassian.net/browse/LOOP-3973 * Revert change accidentally pushed (that would make iOS critical alerts show up while app is in foreground) * LOOP-3974: Make Bluetooth Off a critical alert * Remove `interruptionLevel` from CoreData altogether. It used to be a "convenience" to have the `isCritical` boolean there, but because `interruptionLevel` is really part of `Alert.Content` (and is serialized in the `foregroundContent` and `backgroundContent` fields already), I think keeping this field is at best confusing and at worst misleading. * Hoists interruptionLevel into Alert * Fix primitiveInterruptionLevel * Adds unit test to insure confidence in `interruptionLevel` getter/setter * PR Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.