remove +ve momentum from bolus calculation#372
Merged
ps2 merged 2 commits intoLoopKit:devfrom Feb 19, 2017
Merged
Conversation
Merged
ps2
pushed a commit
that referenced
this pull request
Mar 17, 2021
- https://tidepool.atlassian.net/browse/LOOP-2546 - https://tidepool.atlassian.net/browse/LOOP-3143 - https://tidepool.atlassian.net/browse/LOOP-3144 - https://tidepool.atlassian.net/browse/LOOP-3145 - Refactor AppDelegate into new LoopAppManager class - Refactor onboarding into new OnboardingManager class - Refactor BluetoothStateManager to support deferred authorization and separate state - Update root view controller dependent classes to use provider - Update LaunchScreen and Main root view controller to display system background only - Refactor and remove onboarding related from StatusTableViewController - Defer StatusTableViewController creation until after onboarding - Support multiple onboarding plugins - Use OSLog in PluginManager for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a attempt to address #370. The
recommendBolusfunction calculates a bolus based on both a glucose prediction with momentum, and one without, and returns the smaller bolus of the two.Note that currently the retrospective effect is not used in the bolus calculation without momentum. We will test over the next few days. Any comments welcome.