Only allow one active glucose data source#364
Merged
ps2 merged 5 commits intoLoopKit:devfrom Feb 11, 2017
Merged
Conversation
Separate CGM sources out into their own section and enforce zero or one active sources at any given time. This requires a new boolean value to track whether the G5 transmitter is enabled independently of the actual transmitter ID. While we're at it, create a separate config section for the pump to group it with the pump battery type since those are not really configuration values and go together.
Author
Author
|
Some notes:
|
The top animation is a clearer indication that this is an extension of the G5 Transmitter enabled switch.
loudnate
reviewed
Jan 8, 2017
added 3 commits
January 8, 2017 13:22
dynamic dispatch. Also make the internal methods private for good measure.
Author
|
pull request am i |
Collaborator
|
This looks good to me. Are there parts of the guide that should be updated? |
Collaborator
|
I can do this. Just updating Anna's app now. This went into dev branch though...so I will note that in guide and when it goes to master I'll update the guide for that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Separate CGM sources out into their own section and enforce zero or one
active sources at any given time. This requires a new boolean value to
track whether the G5 transmitter is enabled independently of the actual
transmitter ID.
While we're at it, create a separate config section for the pump to
group it with the pump battery type since those are not really
configuration values and go together.