Enforce a fixed number of fractional digits per unit type.#356
Merged
ps2 merged 3 commits intoLoopKit:devfrom Jan 5, 2017
Merged
Enforce a fixed number of fractional digits per unit type.#356ps2 merged 3 commits intoLoopKit:devfrom
ps2 merged 3 commits intoLoopKit:devfrom
Conversation
added 3 commits
January 2, 2017 13:37
At all times, we prefer: 0 fractional digits for mg/dL 1 fractional digit eliminate the use of significant digits and use fixed a number of fractional digits everywhere. This is in service of: LoopKit#324
This lets us back out the changes to PredictionTableViewController since now the ChartAxisDoubleUnit uses the glucose formatter to represent its value instead of hardcoding an integer formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At all times, we prefer:
0 fractional digits for mg/dL
1 fractional digit
eliminate the use of significant digits and use fixed a number of
fractional digits everywhere.
This is in service of:
#324