Refactor HUD views into LoopUI framework (#284)#330
Merged
ps2 merged 13 commits intoLoopKit:devfrom Jan 1, 2017
Merged
Conversation
added 12 commits
December 11, 2016 16:27
… that it doesn't have to pull in HUDViewKit
1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend.
loudnate
approved these changes
Dec 30, 2016
Collaborator
|
Recommend using "Squash and Merge" strategy to keep a clean commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First approximation of this refactor. Happy to make whatever changes are necessary.