Issue #267 - Displaying decimals on Watch for mmol#303
Closed
alternateal wants to merge 4 commits intoLoopKit:devfrom
alternateal:dev
Closed
Issue #267 - Displaying decimals on Watch for mmol#303alternateal wants to merge 4 commits intoLoopKit:devfrom alternateal:dev
alternateal wants to merge 4 commits intoLoopKit:devfrom
alternateal:dev
Conversation
ps2
requested changes
Dec 4, 2016
|
|
||
| func getCurrentTimelineEntry(for complication: CLKComplication, withHandler handler: (@escaping (CLKComplicationTimelineEntry?) -> Void)) { | ||
|
|
||
| let formatter = NumberFormatter(); formatter.usesSignificantDigits = true; formatter.minimumSignificantDigits = 2; formatter.maximumSignificantDigits = 3 |
Collaborator
There was a problem hiding this comment.
What does this display with mg/dl?
Need to avoid repeating this code three times.
Collaborator
Author
|
Happy to use @bharat's extension (provided it works on watch also) - I knew it was quick and dirty solution - just needed to make something workable for users of mmol/L. Happy to close the thread if you want? |
Collaborator
|
I would rather you keep it open and then update it to use the HKUnit unit extension when it's available! |
Update Dev Branch
Collaborator
|
Once the HKUnit extension is available, include it in the watch target along with |
Collaborator
|
The HKUnit extension has been merged into dev, if you want to rebase and update this PR to use it. |
Collaborator
|
I believe this is resolved properly with #379 |
ps2
pushed a commit
that referenced
this pull request
Nov 16, 2020
… flag (#303) * set insulin delivery log header label colour * blocking entry deletion with existing flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated code to use significant digits to enable decimals to be shown on both watch app and complication.