Merged
Conversation
ps2
pushed a commit
that referenced
this pull request
Oct 4, 2020
* Adjustment to status bar to support narrow displays * using 5/8 and 3/8 for pump pill distribution * updates from discussing with design * stop IB from complaining * moved screen width check to specific view * clean up * use view bounds instead of screen size for narrow display check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
Multiple updates have the potential to interleave, due to being managed by dispatch_groups. Therefore two updates first read the state of the temp basal (e.g. both read nil), then when their async completion runs, the first one sets the temp basal to non-nil and the UITableView is fine, but then the second one also sets it to non-nil and attempts to insert an extra row in the table view.