feat(FillHolesFilter): add vtkFillHolesFilter#3434
Open
daker wants to merge 1 commit intoKitware:masterfrom
Open
feat(FillHolesFilter): add vtkFillHolesFilter#3434daker wants to merge 1 commit intoKitware:masterfrom
daker wants to merge 1 commit intoKitware:masterfrom
Conversation
daker
force-pushed
the
feat-fillholesfilter
branch
from
aecceaa to
b59565f
Compare
finetjul
reviewed
Feb 27, 2026
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
It would have been great to keep the comments from the C++ file.
Maybe it should be mentioned somewhere that it is the same algorithm than the C++.
| let cellId = 0; | ||
| while (polyOffset < polyValues.length) { | ||
| const npts = polyValues[polyOffset]; | ||
| const pts = []; |
Member
There was a problem hiding this comment.
to move outside while loop to lower the number of new allocations
| for (let i = 0; i < npts; i++) { | ||
| const p1 = pts[i]; | ||
| const p2 = pts[(i + 1) % npts]; | ||
| const neighbors = mesh.getCellEdgeNeighbors(cellId, p1, p2); |
Member
There was a problem hiding this comment.
PolyData/index.d.ts indicates that getCellEdgeNeighbors returns void. Can you please fix it ?
| linesPolyData.setLines(newLines); | ||
| linesPolyData.buildLinks(); | ||
|
|
||
| const visited = new Array(numLines).fill(false); |
Member
There was a problem hiding this comment.
I wonder if a typedarray is not "faster" in this situation... (it would be better memory-wise)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #3433 needs to be merged first
Results
add vtkFillHolesFilter
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting