feat: add resetCameraScreenSpace method with offsetRatio input, so actors fully fit the screen#3371
Open
aerogt3 wants to merge 1 commit intoKitware:masterfrom
Open
feat: add resetCameraScreenSpace method with offsetRatio input, so actors fully fit the screen#3371aerogt3 wants to merge 1 commit intoKitware:masterfrom
aerogt3 wants to merge 1 commit intoKitware:masterfrom
Conversation
add resetCameraScreenSpace method with offsetRatio input, essentially a resetCamera call that fills the entire screen space (where 90% offsetRatio means visible actors will fill 90% of the screen space) Kitware#1285
aerogt3
force-pushed
the
1285-fix-resetCameraScreenSpace
branch
from
5173f89 to
3f36750
Compare
finetjul
reviewed
Dec 2, 2025
|
|
||
| return true; | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
why not recoding the VTK C++ implementation ?
This ensures you have the same behavior between VTK C++ and VTK.js. Which is important.
Contributor
Author
There was a problem hiding this comment.
1.) don’t have C++ knowledge
2.) never used VTK C++ (just vtk.js & paraview) Can’t find out how to use/compare resetCameraScreenSpace anywhere in paraview. Either way, #1 is the end of the road.
I think this contribution is better than having nothing, either with the name cameraResetScreenSpace, or maybe cameraZoomExtents. If someone with C++ knowledge can improve it later on (or take this solution to C++ if it’s better) that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add resetCameraScreenSpace method with offsetRatio input, essentially a resetCamera call that fills the entire screen space (where 90% offsetRatio means visible actors will fill 90% of the screen space)
#1285
Context
#1285
Results
See image here:
#1285 (comment)
Changes
Duplicated the resetCamera method, with logic to ensure visible actors fill a percentage of the screen (default: 90%)
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting