Conversation
|
Any comments, suggestions, confusions so far? |
|
Greetings, thank you for sending this PR, it looks good to me. But only the owner of the software @wumpz will be able to merge it and he is very busy at the moment. Please have patience, thank you! |
|
Greetings, you would need to resolve the conflicts and re-submit please. |
…ptions and array types
| } | ||
| String options = PlainSelect.getStringList(tableOptionsStrings, false, false); | ||
| if (options != null && options.length() > 0) { | ||
| if (!options.isEmpty()) { |
There was a problem hiding this comment.
Is this really NULL safe? In JSQLParser, we have (unfortunately) a lot of Lists which can be NULL.
There was a problem hiding this comment.
Yes, it is a StringBuilder result from the PlainSelect#getStringList(...)
There was a problem hiding this comment.
Ok, thanks for checking.
isEmpty is available on Java 8? I recall it was available in Java 11 only?
There was a problem hiding this comment.
yes it is available, since 1.6
Maven build would fail otherwise but it was passed fine
There was a problem hiding this comment.
Ok, sorry for bothering you.
Thanks for the PR, it looks very good in my opinion, well done.
But only @wumpz can merge it eventually. Please be patient.
There was a problem hiding this comment.
Any chance to have it merged this year?
There was a problem hiding this comment.
The project is very active and as accepted a few PRs since your contribution.
Thus you will need to resolve conflicts first (Pull + Merge + Resolve Conflicts + Commit + Push), before your PR can be accepted.
Thank you for understanding.
|
@manticore-projects Is this still active? |
Replaces PR JSQLParser#1415, all credit goes to @s13o Re-arranged some recently added Tokens in alphabetical order Update Keywords
|
Salvaged into PR #1676. |
* support clickhouse global keyword in join * fix: add missing public Getter Add public Getter for `updateSets` Fixes #1630 * feat: Clickhouse GLOBAL JOIN All credits to @julianzlzhang fixes #1615 fixes #1535 * feat: IF/ELSE statements supports Block Make `If... Else...` statements work with Blocks Make `Statement()` production work with `Block()` Rewrite the `Block()` related Unit Tests fixes #1682 * fix: Revert unintended changes to the Special Oracle Tests * fix: `SET` statement supports `UserVariable` Make `SetStatement` parse Objects instead of Names only Add Grammar to accept `UserVariable` (e.g. "set @Flag = 1") Add Test Case for `UserVariable` fixes #1682 * feat: Google Spanner Support Replaces PR #1415, all credit goes to @s13o Re-arranged some recently added Tokens in alphabetical order Update Keywords * fix: fix JSonExpression, accept Expressions Make JSonExpression accept Expressions Add Testcase Expose Idents() and Operators() Fixes #1696 * test: add Test for Issue #1237 Co-authored-by: Zhang Zhongliang <zhangzhongliang@xiaomi.com>
3 participants
add support of a Google Spanner Interleaved table, commit timestamp options and array types