This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Merged
Conversation
shssf
suggested changes
Oct 25, 2019
Contributor
shssf
left a comment
There was a problem hiding this comment.
- I think the initialization part should be implemented in Numba. It will require the PR to Numba repository. I don't believe in magic. Numba know nothing about HPAT if regular user use
conda install numba. So, we have to implement some code in Numba to pickup HPAT if Pandas used in user code. Particular the same as you do in this PR. - Please look into how many libraries are loaded into memory if just
import hpatused in python. I think we need to revise initialization part of the HPAT and load required libraries on demand (not all of them at startup). Perhaps it is better to discuss this offline and maybe in another PR.
Contributor
|
@PokhodenkoSA Do we really need |
Contributor
|
@PokhodenkoSA I would like to merge this PR but we need to move initializer into |
Remove support numba_python tests for numba<0.46 Removed numba_pandas package and tests. Move extension point to hpat/__init__.py
|
Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
shssf
approved these changes
Nov 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows how to create Numba extension for Pandas according the documentation.
See test
numba_pandas/tests/test_pandas.py.Implicit loading of extension is supported in Numba >= 0.46.
Test file also shows how to load extension explicitly for Numba < 0.46.
For HPAT version not ported to Numba 0.46 it is possible to run the test with Numba 0.46:
comment the line
import hpat.compilerinhpat/__init__.py.This test is not in CI yet.
_init_extension()imports only overloads used in the test. It should be extended for all overloads for Pandas.I think we should consider moving Pandas overloads to
numba_pandaspackage.