You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
drop support for maximum and minimum for both float and complex dtypes since they do not bring performance improvement compared to stock NumPy implementation.
I wonder if this performance issue should be passed to MKL team
MKL does not have any equivalent function for maximum and minimum and mkl_umath implementation was based on primitive/built-in operators. This implementation is similar to what was used in numpy-1.22. However, stock numpy-1.23, the implementation was updated which is faster and so current numpy is faster than mkl_umath.
MKL only has equivalent function for float loops of fmax and fmin which are already been used in mkl_umath.
And I am going to drop support for complex loop of fmax and fmin as well since there is no performance improvement there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop support for
maximumandminimumfor both float and complex dtypes since they do not bring performance improvement compared to stock NumPy implementation.timing on:
Intel(R) Xeon(R) Platinum 8480+ OpenCL 3.0 (Build 0) [2025.20.7.0.08_160000.prerelease]on the main branch:
Function
maximum:Function
minimum: