Merged
Conversation
If dtypes list is empty, populate it with first Python scalar from weak_dtypes list.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_148 ran successfully. |
Collaborator
6 tasks
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_151 ran successfully. |
ndgrigorian
previously approved these changes
Oct 23, 2024
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_152 ran successfully. |
vtavana
approved these changes
Oct 23, 2024
Contributor
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @oleksandr-pavlyk for fixing it.
ndgrigorian
approved these changes
Oct 23, 2024
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
Windows tests now passing, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-1874
If inputs consist solely of weak dtypes, pre-prepopulate
dtypeslists with scalar behind the firstweak_dtypeselement.Add tests that
dpt.result_types(sc1, sc2)gives the same result regardless whether the scalar is a Python scalar (weak dtype), or corresponding NumPy scalar (strong dtype).