Explicitly include headers used in the c++ file pertaining to reduction#1802
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Aug 19, 2024
Merged
Explicitly include headers used in the c++ file pertaining to reduction#1802oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
This is a good, recommended practice. Moved global definition of namespaces td_ns and su_ns in reductions.hpp into namespace. Fixed resulting build breakage by including needed headers and defining those namespaces locally in affected files. Changed definition of logaddexp in math_utils to use selector instead of if/else branches to improve performance. Switch revealed silent inefficiency from using std::log1p for all types (for sycl::half it would silently upcast to float and evaluate std::log1p<float>(sycl::half)). Used `if constexpr` to use sycl::log1p for half and single FP types. For double, use std::log1p until the issue is fixed.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_324 ran successfully. |
Collaborator
ndgrigorian
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a good, recommended practice.
Moved global definition of namespaces
td_nsandsu_nsin 'reductions.hpp' into namespace.Fixed resulting build breakage by including needed headers and defining those namespaces locally in affected files.
Changed definition of
logaddexpinmath_utils.hppto use selector instead of if/else branches to improve performance. Switch revealed silent inefficiency from usingstd::log1p for all types (forsycl::halfit would silently upcast to float and evaluatestd::log1p<float>(sycl::half)).Used
if constexprto use sycl::log1p for half and single FP types. For double, use std::log1p until the issue is fixed.