Skip to content

ENH: Update GitHub Actions Ubuntu environment version#194

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:SwitchToUbutu2204
Jan 16, 2023
Merged

ENH: Update GitHub Actions Ubuntu environment version#194
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:SwitchToUbutu2204

Conversation

@jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Jan 12, 2023 •
edited
Loading

Update GitHub Actions Ubuntu environment to version 22.04 in the interest of consistency with the rest of the versions used across ITK.

Change the Python package names:

  • Use python3 instead of python
  • Use python3-pygments instead of python-pygments

as the latter no longer exist in Ubuntu 22.04:
https://packages.ubuntu.com/jammy/python/

@jhlegarreta jhlegarreta changed the title ENH: Switch Github Actions Ubuntu environment ENH: Switch GitHub Actions Ubuntu environment Jan 12, 2023
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure labels Jan 12, 2023
@jhlegarreta
Copy link
Member Author

jhlegarreta commented Jan 12, 2023

ITKRemoteModuleBuildTestPackageAction is using 22.04:
https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/blob/main/.github/workflows/build-test-package-python.yml

ITKSphinxExamples is using 22.04:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/.github/workflows/build-test-publish.yml#L14

ITK itself is still in 20.04:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Testing/ContinuousIntegration/AzurePipelinesLinux.yml
So is the ITKModuleTemplate:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/main/.github/workflows/build-test-package.yml#L16
Although the cookiecutter does use 22.04 through the remotes action:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/build-test-package.yml

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Jan 12, 2023

CI fails because it is unable to install Python 3.7 for this OS version; will rebase on master after #195 gets hopefully merged.

@jhlegarreta jhlegarreta changed the title ENH: Switch GitHub Actions Ubuntu environment ENH: Update GitHub Actions Ubuntu environment version Jan 12, 2023
thewtex
thewtex previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

@jhlegarreta jhlegarreta force-pushed the SwitchToUbutu2204 branch 2 times, most recently from fe57ec8 to b55e29f Compare January 12, 2023 19:45
@jhlegarreta
ENH: Update GitHub Actions Ubuntu environment version
eaee38e 
Update GitHub Actions Ubuntu environment to version `22.04` in the
interest of consistency with the rest of the versions used across ITK.

Change the Python package names:
- Use `python3` instead of `python`
- Use `python3-pygments` instead of `python-pygments`

as the latter no longer exist in Ubuntu `22.04`:
https://packages.ubuntu.com/jammy/python/
@dzenanz dzenanz merged commit 013c3b5 into InsightSoftwareConsortium:master Jan 16, 2023
@jhlegarreta jhlegarreta deleted the SwitchToUbutu2204 branch January 16, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex left review comments

Assignees

No one assigned

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhlegarreta @thewtex @dzenanz