Skip to content

ENH: Fix workflow actions warnings linked to Node.js #193

Merged
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
jhlegarreta:FixGitHubActionsNodejsWarning
Jan 12, 2023
Merged

ENH: Fix workflow actions warnings linked to Node.js #193
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
jhlegarreta:FixGitHubActionsNodejsWarning

Conversation

@jhlegarreta
Copy link
Member

  • ENH: Fix workflow actions warnings linked to Node.js
  • ENH: Bump actions/upload-artifact action to v3

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure labels Jan 12, 2023
thewtex
thewtex previously approved these changes Jan 12, 2023
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

dzenanz
dzenanz previously approved these changes Jan 12, 2023
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a rebase is now needed due to #195.

Fix workflow actions warnings linked to `Node.js`: bump miscellaneous
GitHub actions versions in workflows.

Fixes:
```
Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16:
actions/checkout@v2, actions/setup-python@v1
```

and
```
The `set-output` command is deprecated and will be disabled soon.
Please upgrade to using Environment Files.
For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
```

raised for example in:
https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/actions/runs/3884893720
Bump `actions/upload-artifact` action to v3.
@jhlegarreta jhlegarreta dismissed stale reviews from dzenanz and thewtex via 1cadef0 January 12, 2023 15:45
@jhlegarreta jhlegarreta force-pushed the FixGitHubActionsNodejsWarning branch from 20167bb to 1cadef0 Compare January 12, 2023 15:45
@jhlegarreta
Copy link
Member Author

Looks good, but a rebase is now needed due to #195.

Done. Force-pushed.

@thewtex thewtex merged commit a7f818b into InsightSoftwareConsortium:master Jan 12, 2023
@jhlegarreta jhlegarreta deleted the FixGitHubActionsNodejsWarning branch January 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants