Skip to content

ENH: Use https instead of http when https works#186

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:http2httpsv2
Aug 12, 2022
Merged

ENH: Use https instead of http when https works#186
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:http2httpsv2

Conversation

@jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Jun 3, 2022

https is more tamper-resistant and more private so we use it instead
of http when it is available.

Following
InsightSoftwareConsortium/ITK@9cd0f20

@jhlegarreta
ENH: Use https instead of http when https works
351ec22 
https is more tamper-resistant and more private so we use it instead
of http when it is available.

Following
InsightSoftwareConsortium/ITK@9cd0f20
@github-actions github-actions bot added area:Appendices Issues affecting the Appendices part area:Architecture Issues affecting the Architecture part area:DesignAndFunctionality Issues affecting the Design And Functionality part area:DevelopmentGuidelines Issues affecting the Development Guidelines part area:Introduction Issues affecting the Introduction part language:LaTeX Changes to LaTeX code type:BookStyle Changes to book style files type:Enhancement Improvement of existing methods or implementation type:Infrastructure labels Jun 3, 2022
dzenanz
dzenanz reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a duplicate of #185?

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Jun 3, 2022

Isn't this a duplicate of #185?

Not exactly. Answered offline. The LICENSE file in here is untouched (as I think is the proper thing to do).

thewtex
thewtex approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thewtex thewtex merged commit 13e98c3 into InsightSoftwareConsortium:master Aug 12, 2022
@jhlegarreta jhlegarreta deleted the http2httpsv2 branch August 12, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Appendices Issues affecting the Appendices part area:Architecture Issues affecting the Architecture part area:DesignAndFunctionality Issues affecting the Design And Functionality part area:DevelopmentGuidelines Issues affecting the Development Guidelines part area:Introduction Issues affecting the Introduction part language:LaTeX Changes to LaTeX code type:BookStyle Changes to book style files type:Enhancement Improvement of existing methods or implementation type:Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhlegarreta @thewtex @dzenanz