Skip to content

STYLE: Do not use void in empty function parameter list#172

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:No-void-in-parameter-list
Dec 27, 2021
Merged

STYLE: Do not use void in empty function parameter list#172
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:No-void-in-parameter-list

Conversation

@N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Dec 25, 2021

Following ITK commits:

"STYLE: removing void if used in place of empty parameter list"
by Dženan Zukić (@dzenanz), 11 September 2018
InsightSoftwareConsortium/ITK@60807f4

"STYLE: Remove redundant void argument lists"
by Hans Johnson (@hjmjohnson), 20 February 2020
pull request InsightSoftwareConsortium/ITK#1628
InsightSoftwareConsortium/ITK@e6d859e

In accordance with C++ Core Guidelines, August 19, 2021:
"Don't use void as an argument type"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#nl25-dont-use-void-as-an-argument-type

Clang-Tidy "modernize-redundant-void-arg" check:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html

@github-actions github-actions bot added area:Appendices Issues affecting the Appendices part area:Cover Issues affecting the Cover language:LaTeX Changes to LaTeX code type:BookStyle Changes to book style files type:Style Style changes: no logic impact (indentation, comments, naming) type:Infrastructure labels Dec 25, 2021
Following ITK commits:

"STYLE: removing void if used in place of empty parameter list"
by Dženan Zukić, 11 September 2018
InsightSoftwareConsortium/ITK@60807f4

"STYLE: Remove redundant void argument lists"
by Hans Johnson, 20 February 2020
pull request InsightSoftwareConsortium/ITK#1628
InsightSoftwareConsortium/ITK@e6d859e

In accordance with C++ Core Guidelines, August 19, 2021:
"Don't use void as an argument type"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#nl25-dont-use-void-as-an-argument-type

Clang-Tidy "modernize-redundant-void-arg" check:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html
@N-Dekker N-Dekker force-pushed the No-void-in-parameter-list branch from 5cfc05f to 98dad71 Compare December 26, 2021 12:58
@N-Dekker N-Dekker marked this pull request as ready for review December 27, 2021 13:25
@dzenanz dzenanz merged commit c4d9284 into InsightSoftwareConsortium:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Appendices Issues affecting the Appendices part area:Cover Issues affecting the Cover language:LaTeX Changes to LaTeX code type:BookStyle Changes to book style files type:Infrastructure type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants