Remove sim SimpleWeatherService and implement needed nimble parts#153
Merged
NeroBurner merged 2 commits intomainfrom Sep 25, 2024
Merged
Remove sim SimpleWeatherService and implement needed nimble parts#153NeroBurner merged 2 commits intomainfrom
NeroBurner merged 2 commits intomainfrom
Conversation
We currently have slightly modified InfiniTime version of `SimpleWeatherService.h` and `SimpleWeatherService.cpp`, which need to be updated in sync with InfiniTime. Instead implement the needed parts of the nimble library to make the InfiniTime version of the SimpleWeatherService work.
Collaborator
Author
|
tested against InfiniTimeOrg/InfiniTime#2100 with version InfiniTimeOrg/InfiniTime@c57bbee merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have slightly modified InfiniTime version of
SimpleWeatherService.handSimpleWeatherService.cpp, which need to be updated in sync with InfiniTime.Instead implement the needed parts of the nimble library to make the InfiniTime version of the SimpleWeatherService work.