Conversation
Update to new plugin, fix formatting for GAE J8 Std
googlebot
added
the
cla: yes
Contributor
Author
|
@jabubake FYI |
Contributor
Author
|
I'm going to merge this. Build is broken due to kms. |
tswast
reviewed
Aug 22, 2017
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Love it!
But, some region tags around imports got a bit messed up.
| @@ -1,55 +1,49 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't have been a javadoc.
| @@ -1,16 +1,14 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| new LocalServiceTestHelper( | ||
| // Set no eventual consistency, that way queries return all results. | ||
| // https://cloud.google.com/appengine/docs/java/tools/localunittesting#Java_Writing_High_Replication_Datastore_tests | ||
| // https://cloud.google |
Contributor
There was a problem hiding this comment.
The formatter didn't play nice with this link. 😞
| @@ -1,15 +1,15 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| @@ -1,66 +1,67 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| @@ -1,16 +1,14 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| import javax.servlet.http.HttpServletRequest; | ||
| import javax.servlet.http.HttpServletResponse; | ||
|
|
||
| // [END import] |
Contributor
There was a problem hiding this comment.
It's possible these imports include more than desired for the docs, too.
| @@ -1,16 +1,14 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| @@ -1,16 +1,14 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
| @@ -1,48 +1,46 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
License header shouldn't be a javadoc.
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
9 tasks
anguillanneuf
pushed a commit
that referenced
this pull request
Nov 15, 2022
…820) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.3` -> `2.5.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.5.4`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​254-httpsgithubcomgoogleapisjava-corecomparev253v254-2022-02-11) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.3...v2.5.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
](https://renovatebot.com){kind=link}
This was referenced Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to new plugin, fix formatting for GAE J8 Std