adding java8 spanner sample by jabubake · Pull Request #711 · GoogleCloudPlatform/java-docs-samples

jabubake · 2017-06-15T19:40:28Z

Spanner app engine sample.
FYI, @ludoch

lesv · 2017-06-15T21:25:53Z

appengine-java8/spanner/README.md

+      A database will created using the `SPANNER_DATABASE` name if provided, else will be auto-generated.
+
+## Endpoints
+- `/run` : will run sample operations against the spanner instance in order. Individual tasks can be run


/spanner ??

lesv · 2017-06-15T21:26:06Z

appengine-java8/spanner/README.md

+- Update system properties in `[appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml):
+    - Required : `SPANNER_INSTANCE`
+    - Optional : `SPANNER_DATABASE`,
+      A database will created using the `SPANNER_DATABASE` name if provided, else will be auto-generated.


One or the other???

I cleaned up to be just SPANNER_INSTANCE so its clearer.

lesv · 2017-06-15T21:26:34Z

appengine-java8/spanner/README.md

+You may also [create and use service account credentials](https://cloud.google.com/docs/authentication/getting-started#creating_the_service_account).
+- To run locally, we will be using the [Maven Jetty plugin](http://www.eclipse.org/jetty/documentation/9.4.x/jetty-maven-plugin.html)
+```
+   mvn -DSPANNER_INSTANCE=my-spanner-instance jetty:run


Let's not tell them this - it's not really for J8 Std

THIS IS TEMPORARY - explain why and the issue # they can follow.

Added tracking issue.

lesv · 2017-06-15T21:27:03Z

appengine-java8/spanner/pom.xml

+    <plugins>
+      <plugin>
+        <groupId>org.eclipse.jetty</groupId>
+        <artifactId>jetty-maven-plugin</artifactId>


Let's not have this.

Actually, just comment that this is hear due to a problem in the spanner library that we can't run locally under normal tooling -- GAE development server - GAE API's won't work here.

lesv · 2017-06-15T21:29:20Z

appengine-java8/spanner/src/main/java/com/example/appengine/spanner/SpannerClient.java

+import javax.servlet.ServletContextListener;
+import javax.servlet.annotation.WebListener;
+
+@WebListener


We like having comments about why this makes it so that we don't use web.xml

lesv · 2017-06-15T21:34:59Z

appengine-java8/spanner/src/main/java/com/example/appengine/spanner/SpannerTasksServlet.java

+ * Individual tasks can be run using "tasks" query parameter. {@link SpannerTasks.Task} lists
+ * supported tasks. All tasks are run in order if no parameter or "tasks=all" is provided.
+ */
+@WebServlet(value = "/run")


/spanner - also comment on why this keeps you from needing a web.xml

renamed to /spanner & added comment about annotation

jabubake · 2017-06-15T22:24:35Z

@lesv PTAL

…711) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.1.3` -> `2.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.1.4/compatibility-slim/2.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.1.4/confidence-slim/2.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.1.4`](https://togithub.com/googleapis/java-core/blob/master/CHANGELOG.md#214-httpswwwgithubcomgoogleapisjava-corecomparev213v214-2021-09-15) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.1.3...v2.1.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).

…1.0 (#711) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.0.0` -> `24.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/compatibility-slim/24.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/confidence-slim/24.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).

adding java8 spanner example

1b5b961

jabubake added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 15, 2017

jabubake requested a review from lesv June 15, 2017 19:40

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2017

adding instructions to run locally using the jetty plugin

dba453b

jabubake removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 15, 2017

lesv suggested changes Jun 15, 2017

View reviewed changes

cleanup, adding comments around local deployment workaround

707552b

lesv approved these changes Jun 15, 2017

View reviewed changes

jabubake merged commit bdd8a8a into master Jun 15, 2017

jabubake deleted the appenginej8-spanner branch June 15, 2017 23:03

averikitsch mentioned this pull request Oct 27, 2022

migrate code from googleapis/java-tasks #7368

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-dialogflow #7420

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-document-ai #7427

Merged

9 tasks

Conversation

jabubake commented Jun 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jabubake commented Jun 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jabubake commented Jun 15, 2017 •

edited

Loading