adding code sample for Google Cloud Memorystore by jabubake · Pull Request #1096 · GoogleCloudPlatform/java-docs-samples

jabubake · 2018-05-08T20:05:33Z

No description provided.

kurtisvg

LGTM (minus TODO links)

lesv · 2018-05-08T21:46:21Z

memorystore/redis/gce_deployment/startup-script.sh

+GCS_APP_LOCATION=$(curl -s "http://metadata.google.internal/computeMetadata/v1/instance/attributes/app-location" -H "Metadata-Flavor: Google")
+WAR=$(curl -s "http://metadata.google.internal/computeMetadata/v1/instance/attributes/app-war" -H "Metadata-Flavor: Google")
+
+gsutil cp "$GCS_APP_LOCATION"** .


I wonder a bit about this being correct.

lesv · 2018-05-08T21:48:04Z

memorystore/redis/gce_deployment/startup-script.sh

+
+# Install dependencies from apt
+apt-get update
+apt install -t jessie-backports -yq openjdk-8-jre-headless ca-certificates-java


any reason we aren't on Stretch ?

ie. debian-9

nope, just copied over from another sample. tx for catching

lesv · 2018-05-08T21:50:06Z

memorystore/redis/gce_deployment/startup-script.sh

+mkdir -p /var/log/jetty
+
+# Get Jetty
+curl -L https://repo1.maven.org/maven2/org/eclipse/jetty/jetty-distribution/9.4.4.v20170414/jetty-distribution-9.4.4.v20170414.tar.gz -o jetty9.tgz


9.4.10.v20180503 is latest.

updated. tx

lesv · 2018-05-08T22:13:04Z

memorystore/redis/pom.xml

@@ -0,0 +1,78 @@
+<!--
+  Copyright 2018 Google Inc.


Well, we changed this didn't we.

Will need to release an update and then these repos (will follow up w/ that cleanup) after merge.

We released the update for java-repo-tools earlier today (v1.0.10)

Woot :) great, updated.

lesv · 2018-05-08T22:13:35Z

memorystore/redis/src/main/java/com/example/redis/AppServletContextListener.java

@@ -0,0 +1,73 @@
+/*
+ * Copyright 2018 Google Inc.


lesv · 2018-05-08T22:13:58Z

memorystore/redis/src/main/java/com/example/redis/VisitCounterServlet.java

@@ -0,0 +1,53 @@
+/*
+ * Copyright 2018 Google Inc.


lesv · 2018-05-08T22:14:13Z

memorystore/redis/flex_deployment/app.yaml

@@ -0,0 +1,17 @@
+#  Copyright 2018 Google Inc.


lesv · 2018-05-08T22:14:20Z

memorystore/redis/gce_deployment/deploy.sh

@@ -0,0 +1,60 @@
+#!/bin/bash
+#
+#  Copyright 2018 Google Inc.


lesv · 2018-05-08T22:16:21Z

memorystore/redis/pom.xml

+  <properties>
+    <maven.compiler.target>1.8</maven.compiler.target>
+    <maven.compiler.source>1.8</maven.compiler.source>
+    <jetty>9.4.4.v20170414</jetty>


updated. tx

lesv · 2018-05-08T22:18:01Z

memorystore/redis/src/main/java/com/example/redis/AppServletContextListener.java

+        Thread.currentThread()
+            .getContextClassLoader()
+            .getResourceAsStream("application.properties"));
+    host = config.getProperty("redis.host", "127.0.0.1");


Is there a proxy?

left over from local testing, removed

lesv · 2018-05-08T22:19:34Z

memorystore/redis/src/main/java/com/example/redis/VisitCounterServlet.java

+      Long visits;
+
+      try (Jedis jedis = jedisPool.getResource()) {
+        visits = jedis.incr("visits");


Should this be sharded?

Or a waning that a hot variable like this wouldn't standup to pressure in production.

i think i'm ok with this to limit complexity, given we do phrase this as a simple HTTP example, connection pooling to the redis instance is important to showcase & there are enough Redis variable best practice resources available.

lesv · 2018-05-08T22:20:26Z

memorystore/redis/src/main/resources/application.properties

@@ -0,0 +1,16 @@
+#  Copyright 2018 Google Inc.


lesv · 2018-05-08T22:20:36Z

memorystore/redis/src/main/resources/application.properties

+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+redis.host=127.0.0.1


tx, updated. leftover from local testing.

…docs-samples into redis

memorystore_ region tags

…ocs-samples into redis

jabubake · 2018-05-09T04:31:35Z

@lesv @kurtisvg PTAL

kurtisvg

LGTM

changes were addressed

lesv

LGTM

…#1096) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.10` -> `2.5.11` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.11/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.11/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.11/compatibility-slim/2.5.10)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.11/confidence-slim/2.5.10)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.5.11`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#2511-httpsgithubcomgoogleapisjava-corecomparev2510v2511-2022-03-28) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.10...v2.5.11) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).

adding code sample for Google Cloud Memorystore

085792e

jabubake added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 8, 2018

jabubake requested a review from lesv May 8, 2018 20:05

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2018

Merge branch 'master' into redis

44354dc

jabubake requested a review from kurtisvg May 8, 2018 20:06

kurtisvg previously approved these changes May 8, 2018

View reviewed changes

lesv reviewed May 8, 2018

View reviewed changes

lesv previously requested changes May 8, 2018

View reviewed changes

jabubake added 3 commits May 8, 2018 21:19

Merge branch 'master' of https://github.com/GoogleCloudPlatform/java-…

c61d801

…docs-samples into redis

Addressing review comments

937764a

memorystore_ region tags

Merge branch 'redis' of https://github.com/GoogleCloudPlatform/java-d…

a9571b8

…ocs-samples into redis

jabubake dismissed kurtisvg’s stale review via a9571b8 May 9, 2018 04:28

Adding README links

076722e

jabubake removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 9, 2018

kurtisvg approved these changes May 9, 2018

View reviewed changes

kurtisvg merged commit 02192c4 into master May 9, 2018

kurtisvg deleted the redis branch May 9, 2018 15:27

lesv reviewed May 9, 2018

View reviewed changes

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

Comments

Conversation

jabubake commented May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kurtisvg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jabubake commented May 9, 2018

Uh oh!

kurtisvg left a comment

Choose a reason for hiding this comment

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

jabubake commented May 8, 2018 •

edited

Loading

kurtisvg left a comment •

edited

Loading