feat: attachment customization and handle unsupported attachments#3477
Merged
feat: attachment customization and handle unsupported attachments#3477
Conversation
Contributor
SDK Size
|
khushal87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling unsupported attachments and adds flexibility in rendering URL previews. The main changes include the addition of a new
UnsupportedAttachmentcomponent, updates to context and prop handling for attachments, and improved extensibility for file and URL preview components.Attachment Handling Enhancements
UnsupportedAttachmentcomponent to gracefully render unsupported attachment types, with context and prop integration throughout the codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] Ff5a4848L111R111, Ff5a4848L235R235)UnsupportedAttachmentinstead ofUrlPreviewfor custom/unsupported types.URL Preview Improvements
URLPreviewCompact) and a newurlPreviewTypeprop/context, allowing selection between full and compact previews. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] Ff5a4848L111R111, Ff5a4848L235R235)File Attachment Extensibility
FilePreviewcomponent, allowing easier overrides and improved testability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]FilePreviewvia context for consistent rendering. [1] [2]Context Propagation and Integration
Channel,Attachment, and related hooks to include new components and props (UnsupportedAttachment,FilePreview,URLPreviewCompact,urlPreviewType). [1] [2] [3] [4] [5] [6] [7] [8] Ff5a4848L111R111, [9] [10]Theming and Localization
UnsupportedAttachmentcomponent uses theme and translation context for styling and localization, ensuring consistent appearance and messaging.These changes collectively improve the robustness and flexibility of attachment handling, making it easier to support new attachment types and customize their rendering.