Property values cardinality implementation#374
Merged
jgrewe merged 24 commits intoG-Node:masterfrom Apr 7, 2020
Merged
Conversation
Contributor
Author
|
As further basis for discussion here is an outline of the current cardinality features:
|
achilleas-k
approved these changes
Mar 31, 2020
Member
achilleas-k
left a comment
There was a problem hiding this comment.
LGTM
I assume most of this functionality will be reused for Section->Section and Section->Property.
Contributor
Author
|
When we have figured out the details in the discussion, the concept will also be applied to cardinalities of Sections and Properties, yes. |
jgrewe
approved these changes
Apr 1, 2020
When setting a values cardinality and the current number of values violate the cardinality a warning is printed to the user.
Contributor
Author
|
I'm preparing tests for all new features and will push them once we are happy with the current state of the PR. |
Contributor
Author
|
Pushed tests for hopefully all added features. |
Windows does not support fetching the systems stdout via the 'sys.__stdout__' magic method in all cases.
achilleas-k
approved these changes
Apr 6, 2020
Member
|
@jgrewe I guess you want to review the changes since your approval before merging? |
jgrewe
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to show by example how a cardinality implementation (see issue #361) could look like and provides more grounds for discussion.
The current PR adds the basic cardinality implementation for Property.values. It provides
format.Property.__init__.val_cardinalityaccessor methods.Tests will still be pushed to this PR.
The PR should serve as a basis for discussion before the cardinality feature can be extended to sections and properties as well.