Merged
Conversation
achilleas-k
approved these changes
Aug 21, 2018
Member
achilleas-k
left a comment
There was a problem hiding this comment.
Would it be better to have two scripts, or maybe subcommands of the same script, one for updating to newest ver and one for converting? Do we already have an upgrade script?
I also don't know if I like the name of the command. odmlexportrdf while descriptive doesn't quite sound like a nice command. Why not something like odml2rdf (in the style of dos2unix) or odmltordf (like pdftotext)?
jgrewe
approved these changes
Aug 21, 2018
Member
jgrewe
left a comment
There was a problem hiding this comment.
Nice! Similar to @achilleas-k's comment I find the name a little bit cumbersome. odml2rdf or odmltordf are equally good, imho.
Contributor
Author
|
pyyaml keeps failing on us... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a convenience command line script to the odML package, that searches through a given directory, converts all found odML files to the latest version and exports all odML files to the RDF format. The conversion is focused on converting as many files as possible in mixed repositories, which possibly contain unrelated XML, JSON or YAML or invalid odML files. Therefore all exceptions are ignored, the tool simply prints a report at the end of the conversion to inform about successes and failures.
After pip install, the script can be called by typing
odmlexportrdf [-r] [-o OUT] SEARCHDIRwith the arguments:The PR also updates the version to 1.4.1 to prepare for a release containing the latest RDF changes.