Skip to content

fix(tube): move the getOrCreatChan outside of the goroutine #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertIndie merged 4 commits into from
Mar 21, 2024
Merged

fix(tube): move the getOrCreatChan outside of the goroutine #161

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a2764e
fix : Repeat Set or Get
wyyolo Mar 14, 2024
69c4a0d
fix : Repeat Set or Get
wyyolo Mar 14, 2024
af8ed4b
fix
wyyolo Mar 17, 2024
453a366
fix:NewSourceTube
wyyolo Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions fs/contube/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,20 @@ func NewMemoryQueueFactory(ctx context.Context) TubeFactory {
func (f *MemoryQueueFactory) getOrCreateChan(name string) chan Record {
f.mu.Lock()
defer f.mu.Unlock()
defer func() {
if q, ok := f.queues[name]; ok {
slog.InfoContext(f.ctx, "Get memory queue chan",
"current_use_count", atomic.LoadInt32(&f.queues[name].refCnt),
"name", name)
}()
if q, ok := f.queues[name]; ok {
atomic.AddInt32(&q.refCnt, 1)
return q.c
}
c := make(chan Record, 100)
f.queues[name] = &queue{
c: c,
refCnt: 1,
}
slog.InfoContext(f.ctx, "Set memory queue chan",
"current_use_count", atomic.LoadInt32(&f.queues[name].refCnt),
"name", name)
return c
}

Expand Down Expand Up @@ -85,11 +85,6 @@ func (f *MemoryQueueFactory) NewSourceTube(ctx context.Context, configMap Config
for _, topic := range config.Topics {
t := topic
wg.Add(1)
go func() {
<-ctx.Done()
f.release(t)
}()

go func() {
defer wg.Done()
c := f.getOrCreateChan(t)
Expand Down