Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
userDataNBT compound tag insideCastingImages into a typed component system. Components are deserialized once along with the rest of the image—referring to its component type to determine how to deserialize—and they are serialized once along with the rest of the image.This would prevent a large deal of unneeded serialization and deserialization for the ravenmind and features in addons that may take a long time to serialize and deserialize by only doing them once and working on a copy in memory. There has been reported massive slowdowns with the ravenmind in hexes that need to iterate often, and from my testing, this seems to have fixed it.
Also adds the concept of a transient component, which disappears when the 'cast' it is created in—from start to when the continuation queue empties at the end of
queueAndExecuteIotasright before the casting environmentpostCastcallback—ends. This fixes unintuitive behavior such as the +1 tax for impulses on the single entity persisting for the entire duration of a spell circle or staff cast, which can stick around arbitrarily long. Now, the jump between slates and right after a pattern is drawn, transient components are cleared.