Allow services to be created with custom transport#44
Merged
FalkTannhaeuser merged 2 commits intoFalkTannhaeuser:zeepfrom Apr 17, 2019
GeertvanHorrik:pr/async-services
Merged
Allow services to be created with custom transport#44FalkTannhaeuser merged 2 commits intoFalkTannhaeuser:zeepfrom GeertvanHorrik:pr/async-services
FalkTannhaeuser merged 2 commits intoFalkTannhaeuser:zeepfrom
GeertvanHorrik:pr/async-services
Conversation
10 tasks
hunterjm
reviewed
Apr 12, 2019
| portType=portType, | ||
| dt_diff=self.dt_diff, | ||
| binding_name=binding_name, | ||
| transport=self.transport) |
There was a problem hiding this comment.
self.transport gets set in the __init__ method, so you should be able to pass your AsyncTransport when calling ONVIFCamera(transport=my_async_transport) instead of doing this logic and passing down to the other create services.
Author
There was a problem hiding this comment.
No, because the ONVIFCamera does service calls itself and is not async-aware.
moisesmejiabs
pushed a commit
to moisesmejiabs/python-onvif-zeep
that referenced
this pull request
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43
This allows any caller to await the services async, e.g.: