Skip to content

fix the way bulk update endpoints in finding view works in v3#14411

Open
dogboat wants to merge 1 commit intoDefectDojo:bugfixfrom
dogboat:locations_bulk_edit_fix
Open

fix the way bulk update endpoints in finding view works in v3#14411
dogboat wants to merge 1 commit intoDefectDojo:bugfixfrom
dogboat:locations_bulk_edit_fix

Conversation

@dogboat
Copy link
Contributor

@dogboat dogboat commented Feb 27, 2026

This PR updates the 'bulk update endpoints' functionality in the Finding view to work when V3/Locations are enabled. When using V3, the bulk edit options change to being radio buttons instead of checksbox since only one status can be set at a time in the new model.

<div class="panel panel-default table-responsive">
<div class="panel-heading">
<h4>Vulnerable Endpoints / Systems ({{ finding.active_endpoint_count }}) </h4>
<h4>Vulnerable Endpoints / Systems ({{ finding.active_endpoint_count }})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the actual fix at hand but I noticed the extra hd close tag here was causing the chevron to render oddly.

<input type="hidden" name="return_url" value="{{ request.get_full_path }}" />
</form>

<div class="hidden" style="padding-bottom: 5px;" id="bulk_edit_menu">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole chunk was really just moved below so the bulk edit button appears closer to the endpoints lists.

@dryrunsecurity
Copy link

DryRun Security

🟡 Please give this pull request extra attention during review.

This pull request includes a risky use of Django's safe filter in dojo/templates/dojo/snippets/endpoints.html (lines 259–261) on endpoint.auditor, which disables automatic escaping and can allow cross-site scripting if that value is not properly sanitized. Consider removing safe, ensuring the value is trusted, or explicitly sanitizing/escaping output to mitigate XSS.

🟡 Potential Cross-Site Scripting in dojo/templates/dojo/snippets/endpoints.html (drs_b9abb469)
Vulnerability Potential Cross-Site Scripting
Description The template uses the safe filter on endpoint.auditor, which disables Django's automatic escaping for that value and can allow untrusted input to inject HTML/JS, leading to XSS if the content is not sanitized.

<td>{{ endpoint.auditor|safe }}</td>
<td>{{ endpoint.audit_time|date }}</td>
{% else %}


All finding details can be found in the DryRun Security Dashboard.

@Maffooch Maffooch added this to the 2.56.0 milestone Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants