Auto Create Context: Fetch all objects for correct jira project associations#14259
Merged
Auto Create Context: Fetch all objects for correct jira project associations#14259
Conversation
…e product reference
…portAndPushTestApi
3 tasks
| import_reimport_config = self._test_setup_jira_project_for_engagement() | ||
| # Not run the import again | ||
| import1 = self.reimport_scan_with_params( | ||
| import_reimport_config.pop("test_id", None), |
Member
There was a problem hiding this comment.
i don't think there is a test_id for this scenario
Suggested change
| import_reimport_config.pop("test_id", None), | |
| None |
valentijnscholten
approved these changes
Feb 7, 2026
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Surprised this only pops up now, maybe now many people are using autocreate?
rossops
approved these changes
Feb 9, 2026
Jino-T
approved these changes
Feb 9, 2026
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
…xt-patch Auto Create Context: Fetch all objects for correct jira project associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using auto create context, the previous implementation was only fetching products successfully if they already existed, but did not fetch an engagement or test. Because of this, jira settings on an engagement that were not inherited from a product were never considered when determining if the the import/reimport should be pushed to jira.
Until this case occured, it appeared as if auto create context was functional because existing engagements/tests were being fetched at the serializer level after the auto create context process occurred at the viewset level