Skip to content

Added relevant test name to "close old findings" comment#13930

Merged
Maffooch merged 3 commits intoDefectDojo:bugfixfrom
Jino-T:more-detailed-close-old-finding-comment
Dec 25, 2025
Merged

Added relevant test name to "close old findings" comment#13930
Maffooch merged 3 commits intoDefectDojo:bugfixfrom
Jino-T:more-detailed-close-old-finding-comment

Conversation

@Jino-T
Copy link
Contributor

@Jino-T Jino-T commented Dec 18, 2025

[sc-12108]

Let me know if you have a better idea for formatting the message
image

@dryrunsecurity
Copy link

dryrunsecurity bot commented Dec 18, 2025

DryRun Security

🔴 Risk threshold exceeded.

This pull request modifies a sensitive file (dojo/importers/default_importer.py) with multiple detected edits; reviewers should verify these changes against configured sensitive paths and allowed authors in .dryrunsecurity.yaml before merging. No edits were marked blocking, but the findings are flagged as failing risk threshold and warrant careful review.

🔴 Configured Codepaths Edit in dojo/importers/default_importer.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/importers/default_importer.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/importers/default_importer.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.

We've notified @mtesauro.


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten valentijnscholten added this to the 2.53.4 milestone Dec 18, 2025
@Jino-T Jino-T requested a review from dogboat December 19, 2025 17:37
@valentijnscholten valentijnscholten modified the milestones: 2.53.4, 2.53.5 Dec 22, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 7af3db2 into DefectDojo:bugfix Dec 25, 2025
278 of 279 checks passed
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
…13930)

* added relevant test name to close old findings comment

* Added test url to close old finding comment

* Better handling for close old findings comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants