CMLDEV-934 Drop deprecated endpoints and fields in CML 2.11 API#195
Open
CMLDEV-934 Drop deprecated endpoints and fields in CML 2.11 API#195
Conversation
Drop deprecated `labs` payload support in group management and remove deprecated lab/group accessors in favor of association-only APIs.
Drop the removed `offline` keyword from ClientLibrary.import_lab and update its regression test to assert the argument is rejected.
Remove deprecated no-argument behavior from ClientLibrary.get_diagnostics and update tests to pass categories explicitly or assert a ValueError.
Drop the legacy `nodes` constructor argument and property from ComputeHost and keep node summary access via `node_counts` and diagnostics endpoints.
Delete legacy public `push_to_server` parameters from model update methods and keep server-sync behavior through internal `_update(..., push_to_server=...)` pathways.
tmikuska
requested review from
BregaladTaran,
PatrikMosko,
marpauli-cisco,
rschmied,
virlos,
vprysiaz and
xorrkaz
tmikuska
commented
Feb 27, 2026
| with open(topology_file_path) as fh: | ||
| topology_file = fh.read() | ||
| with pytest.deprecated_call(): | ||
| with pytest.raises(TypeError): |
Collaborator
Author
There was a problem hiding this comment.
we usually do not test remove code, so this can be removed, but doesn't hurt
tmikuska
commented
Feb 27, 2026
| "ClientLibrary.get_diagnostics(DiagnosticsCategory.ALL) " | ||
| "or provide one or more explicit categories." | ||
| ) | ||
| categories = [DiagnosticsCategory.ALL] |
Collaborator
Author
There was a problem hiding this comment.
this seems a little harsh, but displaying what we usually do
I'd prefer to make ALL the default option instead even though it doesn't match API behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.