BB2-3555: Final adjustments for C4DIC FE POC#87
Merged
jimmyfagan merged 6 commits intofeature/c4dicfrom Dec 19, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3555
What Does This PR Do?
The changes here are partially adding in the ability to load default data instead of authenticating with a running server, and partially adjusting the rendering of the Digital Insurance Card, including some spacing changes, and some content changes, particularly to the entitlement reason in Part A coverage, and various minor items in Part C coverage
What Should Reviewers Watch For?
There are some small anti-pattern type things which we would fix if this was to go into "production" (mostly related to spacing). This is likely tolerable as a POC, but if there are obvious easy improvements, I'm open to those too! I'm not a FE developer so there are often easier ways of doing things that I might not be aware of.
Validation
Run the sample client locally to verify changes. First set the
useDefaultDataButtonsetting to true in patientData.tsx to use default data.