Skip to content

Comments

BB2-3524: Contract ID and formatting updates#83

Merged
jimmyfagan merged 2 commits intofeature/c4dicfrom
feature/c4dic-bb2-3524
Nov 19, 2024
Merged

BB2-3524: Contract ID and formatting updates#83
jimmyfagan merged 2 commits intofeature/c4dicfrom
feature/c4dic-bb2-3524

Conversation

@jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Nov 19, 2024

JIRA Ticket:
BB2-3524

What Does This PR Do?

  • Some minor edits to eliminate code warnings
  • Adjustments to processing of coverage type (instead of Part C/Part D, that field now comes back with -)
  • Remove apparently unused css
  • Minor css adjustments

What Should Reviewers Watch For?

Nothing in particular, just check that the changes make sense and render properly.

Validation

Validated by running the sample client against my local server from the feature/c4dic web-server branch.
I see the below card when running with BBUser10000 (I think that was the user anyway):
image

@jimmyfagan jimmyfagan marked this pull request as ready for review November 19, 2024 18:53
Copy link

@loganbertram loganbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like expected, matches the linked screenshot. Everything seems to be in order

@jimmyfagan jimmyfagan merged commit e28c765 into feature/c4dic Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants