jimfuqian/BB2-3280 Update POC frontend for C4DIC according to designs from FIGMA#76
Merged
JFU-NAVA-PBC merged 4 commits intofeature/c4dicfrom Sep 9, 2024
Conversation
…fd.cms.gov, hack client config ENV=LOCAL: replace localhost with host IP e.g. 192.168.0.104 to workround a connect issue...
6 tasks
loganbertram
approved these changes
Sep 4, 2024
loganbertram
left a comment
There was a problem hiding this comment.
This looks great! I still get a 500 when using as an authorized user, but I see that this ticket pertains to the frontend which is looking fantastic.
If that behavior is expected currently, this is good to go!
| @@ -0,0 +1,3023 @@ | |||
| CARD_IMG_PNG = ''' | |||
There was a problem hiding this comment.
I love storing images like this. I think it's probably better as an asset file that gets loaded by python than as a python file, but that's really overkill for current stage. Just spitballing.
…ntained C4DIC Org, render coverage info using C4DIC Color Palette extension etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3280
Background
Part of the overall Digital Insurance Card POC includes showing how a 3rd party app might use the C4DIC resources to display a real insurance card. Starting from the first iteration of that app started in BB2-3259, we would now like to spruce up that first visualization of the digital insurance card by displaying something aligned with the designs developed by BB2 design team
What Does This PR Do?
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
Steps to play locally: