fix(lint): extract helper function to reduce statement count in MCP rest_endpoints

[shin-bot-litellm]

Summary

Fixes the ruff PLR0915 lint error (too many statements) in call_tool_rest_api function.

Changes

Extracted the allowed MCP servers resolution logic with IP filtering into a dedicated helper function _resolve_allowed_mcp_servers_with_ip_filter.

This reduces the statement count in call_tool_rest_api from 51 to under 50.

Root Cause

PR #20607 (MCP Gateway - Allow setting MCP Servers as Private/Public available on Internet) replaced the previous _resolve_allowed_mcp_servers_for_tool_call helper with inline code, which pushed the function over 50 statements.

Testing

• ruff check --select PLR0915 passes
• Full ruff check passes
• No functional changes - only refactoring

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
litellm	Ready	Preview, Comment	Feb 7, 2026 3:35am

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Shin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[greptile-apps]

Greptile Overview

Greptile Summary

• Refactors MCP call_tool_rest_api by extracting allowed-server resolution + IP filtering into a helper to satisfy Ruff PLR0915.
• Keeps request-time behavior in litellm/proxy/_experimental/mcp_server/rest_endpoints.py, aiming for no functional changes.
• Moves the “which MCP servers are callable from this client IP?” logic into _resolve_allowed_mcp_servers_with_ip_filter, reducing statement count and improving readability.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk.
• Changes are a behavior-preserving refactor to satisfy Ruff PLR0915 by extracting existing allowed-server/IP-filter logic into a helper; review found no altered conditions, return types, or exception behavior on the request path.
• No files require special attention

Important Files Changed

Filename	Overview
litellm/proxy/_experimental/mcp_server/rest_endpoints.py	Extracts allowed MCP server resolution + IP filtering into _resolve_allowed_mcp_servers_with_ip_filter to reduce call_tool_rest_api statement count; refactor appears behavior-preserving with the same 403 behavior when server is not allowed.

Sequence Diagram

sequenceDiagram
  autonumber
  participant C as Client
  participant RE as rest_endpoints.py
  participant AC as build_effective_auth_contexts
  participant MM as global_mcp_server_manager

  C->>RE: POST /mcp/tool/call (call_tool_rest_api)
  RE->>RE: _resolve_allowed_mcp_servers_with_ip_filter(request, user_api_key_dict, server_id)
  RE->>AC: build_effective_auth_contexts(user_api_key_dict)
  AC-->>RE: auth_contexts[]
  RE->>RE: collect allowed_mcp_server_ids
  RE->>MM: filter_server_ids_by_ip(allowed_ids, request.client.host)
  MM-->>RE: filtered_server_ids
  alt server_id not in filtered_server_ids
    RE-->>C: 403 HTTPException (MCP server not allowed)
  else server allowed
    RE->>MM: get_server(server_id)
    MM-->>RE: MCPServer
    RE-->>C: continue tool call using server config
  end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}