feat: add faster linting targets for development workflow#19729
Merged
krrishdholakia merged 7 commits intoBerriAI:litellm_oss_staging_02_04_2026from Feb 4, 2026
Merged
Conversation
- Add lint-dev target that only checks changed files vs origin/main - Add lint-format-changed to format only modified Python lines - Add lint-ruff-dev using diff-quality for incremental lint checks - Upgrade ruff from 0.1.x to 0.2.x for --range formatting support - Add pylint and diff-cover as dev dependencies - Use portable PIP variable for cross-platform compatibility - Suppress poetry warnings in install-dev target
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The type: ignore[attr-defined] comment was on the import alias line inside parentheses, but mypy reports the error on the `from` line. Collapse to single-line imports so the suppression is on the correct line. Also add no-redef to the fallback branch.
- Remove poetry lock/check from install-dev (slow, can mutate lockfile) - Remove misplaced [virtualenvs] and [installer] from pyproject.toml (these belong in poetry.toml, not project metadata) - Remove unused pylint dev dependency (diff-quality uses pylint output format, not the pylint package itself) - Fix trailing whitespace in .PHONY declaration - Use mktemp instead of hardcoded /tmp/ruff.txt in lint-ruff-dev - Guard lint-ruff-FULL-dev against empty file list from git diff - Fix incorrect comment on lint-dev target - Regenerate poetry.lock Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove poetry lock/check from install-dev (slow, can mutate lockfile) - Remove misplaced [virtualenvs] and [installer] from pyproject.toml (these belong in poetry.toml, not project metadata) - Remove unused pylint dev dependency (diff-quality uses pylint output format, not the pylint package itself) - Fix trailing whitespace in .PHONY declaration - Use mktemp instead of hardcoded /tmp/ruff.txt in lint-ruff-dev - Guard lint-ruff-FULL-dev against empty file list from git diff - Fix incorrect comment on lint-dev target - Regenerate poetry.lock
…nto feature/faster-linter
Contributor
Author
|
Integrated #20351 in order to make lint pass. |
krrishdholakia
changed the base branch from
main
to
litellm_oss_staging_02_04_2026
krrishdholakia
merged commit 18f4b72
into
BerriAI:litellm_oss_staging_02_04_2026
6 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Couldn't find an open issue, but on my experience, ruff linter runs slowwww because of checking absolutely the whole basecode. All of it. This PR introduces an improved version for running ruff linter, when developing.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
Type
🆕 New Feature
🧹 Refactoring
🚄 Infrastructure
✅ Test
Changes