Merged
Conversation
Fix copy-pasta in one sub-test so it tests what it claims. Add a test that call_assert macros can be invoked from a pure function
This procedure is similar to assert, but enforcement is unconditionally enabled (ignores the `ASSERTIONS` define). Potentially useful in callers where performance is not a concern but correctness checking is critical. Currently undocumented.
This ensures that call_assert() macro invocations always respect the *current* (possibly locally defined) value of ASSERTIONS, regardless of ASSERTIONS setting used to build the assert_m module.
bonachea
force-pushed
the
assert_always
branch
from
9727282 to
b37b5d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that
#define ASSERTIONS 1in source code is honored by thecall_assertmacros, regardless of theASSERTIONSsetting used to buildassert_m