Change assertion enforcement control knob to ASSERTIONS=1/0#41
Merged
rouson merged 7 commits intoBerkeleyLab:mainfrom Oct 4, 2024
Merged
Change assertion enforcement control knob to ASSERTIONS=1/0#41rouson merged 7 commits intoBerkeleyLab:mainfrom
rouson merged 7 commits intoBerkeleyLab:mainfrom
Conversation
(cherry picked from commit d3e23f0)
The DEBUG=def/undef macro control knob for the call_assert* macros is renamed to ASSERTIONS, and changed to a non-zero/zero value convention. When undefined, ASSERTIONS is given the default value of 0 (disabling the call_assert macros). Update test and example to match the new convention.
gfortran's preprocessor is happy with a blank line break, but ifx insists on a backslash (which gfortran also accepts). So update recommended best practice to backslash continuation
Member
Author
|
In testing this PR I just noticed that CI is failing with |
rouson
requested changes
Oct 4, 2024
Co-authored-by: Damian Rouson <rouson@lbl.gov>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deploys a unified preprocessor control knob
ASSERTIONS=1/0to control all assertion calls.When undefined,
ASSERTIONSis given the default value of0(disabling assertions).The first commit is cherry-picked from PR #31, and supersedes that PR.